It WONT STOOOP!

hello!

im trying rgb led strip light colour when press button 1.

then should fade out

and should wait me push button again

but happens ... push button comes on! , doesnt turn off , keeps cycling though colours!

code: [select]


const int ledpinr = 9;
const int ledping= 11;
const int ledpinb = 10;

const int buttonpin1 = 3;

int buttonstate1 = 0;

byte redpwr = 0;
byte greenpwr = 0;
byte bluepwr = 0;

void setup()
{
 pinmode(ledpinr, output);
 pinmode(ledping, output);
 pinmode(ledpinb, output);


 pinmode(buttonpin1, input);
 buttonstate1 = digitalread(buttonpin1);

 // serial debugging purposes only
 serial.begin(9600);
}
void loop()
{
 buttonstate1 = digitalread(buttonpin1);
 if (buttonstate1 == low){
   redpwr = 255;
   bluepwr = 125;
   analogwrite(ledpinr, redpwr);
   greenpwr = 100;
   analogwrite(ledping, greenpwr);
   analogwrite(ledpinb, bluepwr);

   lightandfade3();
 }
 else {
digitalwrite(ledpinr, low);
digitalwrite(ledping, low);
digitalwrite(ledpinb, low);
 }

}


void lightandfade3()
{
 // fade in min max in increments of 5 points:
 for(int fadevaluer = 255 ; fadevaluer <= 255; fadevaluer +=5)
   for(int fadevalueg = 125 ; fadevalueg <= 125; fadevalueg +=5)
     for(int fadevalueb = 100 ; fadevalueb <= 100; fadevalueb +=5) {
       // sets value (range 0 255):
       analogwrite(ledpinr, fadevaluer);
       analogwrite(ledping, fadevalueg);
       analogwrite(ledpinb, fadevalueb);
       delay(30);
     }



 // fade out max min in increments of 5 points:
 for(int fadevaluer = 255  ; fadevaluer >= 0; fadevaluer -=5)
   for(int fadevalueg = 125  ; fadevalueg >= 0; fadevalueg -=5)
     for(int fadevalueb = 100  ; fadevalueb >= 0; fadevalueb -=5){

       // sets value (range 0 255):
       analogwrite(ledpinr, fadevaluer);
       analogwrite(ledping, fadevalueg);
       analogwrite(ledpinb, fadevalueb);
       // wait 30 milliseconds see dimming effect
       delay(30);
     }
}



any suggestions!

please!

quote

any suggestions!

you've got "serial" initialised - why don't add debug prints?

is pushbutton maybe latching?

maybe check of "for" loops?

Arduino Forum > Forum 2005-2010 (read only) > Software > Syntax & Programs > It WONT STOOOP!

arduino